Add ignore_args support for tool trajectory evaluation#6079
Open
allenjoshua16 wants to merge 4 commits into
Open
Add ignore_args support for tool trajectory evaluation#6079allenjoshua16 wants to merge 4 commits into
allenjoshua16 wants to merge 4 commits into
Conversation
Collaborator
|
Hi @allenjoshua16 , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing mypy-diff tests before we can proceed with the review. |
rohityan
added
the
request clarification
Author
|
Thanks for the feedback. I've addressed the mypy-diff failure and pushed an additional commit to the PR. The issue was caused by mypy reporting a pytest tests/unittests/evaluation/test_trajectory_evaluator.py -q
# 35 passedPlease let me know if there are any other issues I should address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
Tool trajectory evaluation currently compares both tool names and argument values when matching expected and actual tool calls.
This can cause valid evaluations to fail when tool arguments contain dynamic or non-deterministic values such as timestamps, generated queries, or other runtime-generated content.
Solution:
Added an
ignore_argsoption toToolTrajectoryCriterion.When enabled, tool trajectory matching compares only tool names and ignores argument values. This behavior is supported across all existing match modes:
EXACTIN_ORDERANY_ORDERUpdated
TrajectoryEvaluatorto pass this configuration into the matching logic while preserving the existing behavior by default (ignore_args=False).Added unit tests covering:
ignore_argsconfiguration loadingTesting Plan
Unit Tests:
Tested with: